Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with invalid order of args in merklization recursion #160

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

dr-orlovsky
Copy link
Member

Closes #159

@dr-orlovsky dr-orlovsky added the bug Something isn't working label Mar 15, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Mar 15, 2024
@dr-orlovsky dr-orlovsky requested review from crisdut and zoedberg March 15, 2024 19:17
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.2%. Comparing base (5359d84) to head (941eb39).
Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #160     +/-   ##
========================================
- Coverage    76.7%   68.2%   -8.4%     
========================================
  Files          19      20      +1     
  Lines        1710    1999    +289     
========================================
+ Hits         1311    1364     +53     
- Misses        399     635    +236     
Flag Coverage Δ
rust 68.2% <100.0%> (-8.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky self-assigned this Mar 16, 2024
Copy link
Member

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 941eb39

@dr-orlovsky dr-orlovsky merged commit 588e1a3 into master Mar 18, 2024
23 checks passed
@dr-orlovsky dr-orlovsky deleted the fix/159 branch December 23, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large MPC trees sometimes overflow during merklization
2 participants